Spot the error

[ramesh]

Here's some actual VB6 code. Can you spot the error that will cause the program to malfunction?
The premise here: There are five locations, but the data is stored both in remote computers (locations 0-5) or on the local hard drive (6-11). Check_Stores contains the code to run on the data and is not part of the problem

Private Sub cmdStart_Click()

StatusBar1.Panels(1).Text = "Please wait....."
On Error GoTo ErrorHandler

StartNumber = 0 ' 1'st Number (0 or 6)
EndNumber = 5 ' 6th Item (Last Item 5 or 11)
LocationNumber = 0 ' Location Index (0-5)
optIndex = 0 ' Indicates location and whether remote (0-5) or local (6-11)

If chkAllStores.Value = Checked Then ' Do All Stores
    If chkLocal.Value = Checked Then  ' Use local files
        StartNumber = StartNumber + 6
        EndNumber = EndNumber + 6
    End If
    For optIndex = StartNumber To EndNumber
        Option1(LocationNumber).Value = True
        Call Check_Stores
        LocationNumber = LocationNumber + 1
    Next optIndex

Else 'Single Location
    If chkLocal.Value = Checked Then optIndex = optIndex + 6 ' Use local files
    Call Check_Stores
End If

ErrorHandler:
Select Case Err.Number
    Case 0
        ' Do Nothing
    Case 20
        ' Do Nothing
    Case Else
        MsgBox (Err.Number & "  " & Err.Description)
        Err.Clear
End Select
Resume Next

End Sub

[ramesh]

The error is in this line:

optIndex = 0 ' Indicates location and whether remote (0-5) or local (6-11)

The optIndex variable does not need to be initialised as zero, as it is needed to identify the location chosen in the case of the single location.
In the case of the multiple location call to Check_Stores optIndex will be incremented from StartNumber to EndNumber.

Thanks to all who participated.

Yes, I know I'm being sarcastic.....

[Arch_Angel]

The error is in this line:

optIndex = 0 ' Indicates location and whether remote (0-5) or local (6-11)

The optIndex variable does not need to be initialised as zero, as it is needed to identify the location chosen in the case of the single location.
In the case of the multiple location call to Check_Stores optIndex will be incremented from StartNumber to EndNumber.

Thanks to all who participated.

Yes, I know I'm being sarcastic.....

It does not "need" to be initialized but I don't see where it would prevent the program from running.

For the multiple location, the optIndex will start at StartNumber and be incremented.
For the single location, it will add 6 to the number.

In both situations, if the value of optIndex is 0, it won't prevent the program from executing.

I looked the code over and over and couldn't see a problem with it, so I didn't respond.

[ramesh]

Point taken AA, but even if the program continued running it can still malfunction.

My boss considered it an epic fail when it didn't deliver the expected results. He'll remember that more than when I corrected the problem code and it actually gave proper results.

[Arch_Angel]

Point taken AA, but even if the program continued running it can still malfunction.

Malfunction how? Unless you're using the optIndex somewhere else in your code?

You're saying you removed the code that initialized the optIndex and the code produced the results you were looking for?

[ramesh]

It was not mentioned explicitly, I know, but the optIndex variable was assigned elsewhere. The user would choose the location from a set of six option buttons that are indexed 0-5 in a frame.

If you read the note beside the incorrect command, it basically implies this.

' Indicates location and whether remote (0-5) or local (6-11)

[CGPGroup]

There are five locations but the code is looking at 6 indexes (0,1,2,3,4,5 for remote) and (6,7,8,9,10,11 for local).